Fix #3185 #3186
Merged
Fix #3185 #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acinader
approved these changes
Dec 6, 2016
| this.keys.add('updatedAt'); | ||
| case 'keys': { | ||
| const keys = restOptions.keys.split(',').concat(AlwaysSelectedKeys); | ||
| this.keys = Array.from(new Set(keys)); |
| this.keys.add('objectId'); | ||
| this.keys.add('createdAt'); | ||
| this.keys.add('updatedAt'); | ||
| case 'keys': { |
Contributor
There was a problem hiding this comment.
hm. { in case, new one on me.
Contributor
Author
There was a problem hiding this comment.
yeah to create a scope: http://eslint.org/docs/rules/no-case-declarations
| done(); | ||
| }) | ||
| }); | ||
|
|
Jcarlosjunior
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 13, 2016
* Adds tests that reproduce the issue * Use values from keys to force include when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
select() (i.e.: keys)with nested keysa.bparse-server doesn't include by defaultawhich make the call fail (unless you haveinclude('a')specified).This PR addresses that issue and will simplify the behaviour (and code for the clients).
For ex, calling select
a.b.cwill not include full objectsaanda.bbut only the necessary path to resolve correctly thekeysclause.Fixes #3185